Re: [PATCH] xfs_io: add sync and syncfs commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/27/14 6:43 AM, Brian Foster wrote:
> On Fri, Oct 24, 2014 at 01:06:09PM -0500, Eric Sandeen wrote:

...

>> +void
>> +sync_init(void)
>> +{
>> +	sync_cmd.name = "sync";
>> +	sync_cmd.cfunc = sync_f;
>> +	sync_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK;
> 
> Not a big deal given that we have sync(1), but CMD_NOFILE_OK..?
> 
> The rest looks good to me.
> 
> Brian

Ah, good eye, thanks.  Will send V2.

-Eric

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux