Re: [PATCH] xfsprogs: enable sparse checking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 24, 2014 at 10:48:55AM -0500, Eric Sandeen wrote:
> On 10/24/14 10:40 AM, Christoph Hellwig wrote:
> > strong opinion.  It's not like your patch prevents me from using CC=cgcc
> 
> To get endian checking with your method, you'd need to edit
> the Makefile to add the -D define, right?

That's a kernel special, I just did a test run using CC=cgcc and I get
endianess warnings:

rdwr.c:190:21: warning: incorrect type in assignment (different base types)
rdwr.c:190:21:    expected restricted __le32 [usertype] h_crc
rdwr.c:190:21:    got restricted __be32 [usertype] <noident>

log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64
log_misc.c:621:59: warning: cast to restricted __be64

There's also tons of noise that should be easily upgradeable, but let me
check latests xfsprogs first..

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux