> +int
> +xfs_init_utf8_module(struct xfs_mount *mp)
> +{
> + request_module("utf8norm");
> +
> + spin_lock(&utf8norm_lock);
> + if (utf8norm_initialized) {
> + spin_unlock(&utf8norm_lock);
> + return 0;
> + }
> +
> + utf8version_is_supported_func = symbol_get(utf8version_is_supported);
> + if (!utf8version_is_supported_func)
> + goto error;
> +
> + utf8nfkdi_func = symbol_get(utf8nfkdi);
> + if (!utf8nfkdi_func)
> + goto error;
Please export a structure with a function pointes so that we just need
a single symbol_get call. I'd have to look up how symbol_get works,
but unless there's something that speaks against this it might be
simpler to than just do a symbol_get per mounst structure that uses
utf8 and can point to that structure so that we don't have to add
additional reference counting infrastructure around it.
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
