On Wed, Oct 01, 2014 at 07:59:59AM -0400, Brian Foster wrote: > On Tue, Sep 30, 2014 at 11:46:05AM +1000, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > Currently the extent size hint is set unconditionally in > > xfs_ioctl_setattr(), even when the FSX_EXTSIZE flag is not set. This > > means we can set values from uninitialised stack variables. Hence > > only set the extent size hint from userspace when both the mask > > falg is set and the inode has the XFS_DIFLAG_EXTSIZE flag set to > > indicate that we should have an extent size hint set on the inode. > > > > I'm not sure what you mean here by FSX_EXTSIZE not being checked. It > looks like FSX_EXTSIZE is checked before and after the patch. Yup, I wrote the commit message, then did the fix and forgot to update the message after I realised it was wrong. I've fixed the commit message. > Regardless, the fix looks Ok to me... > > Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx> Thanks! -Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
