On Fri, Sep 26, 2014 at 04:42:38AM -0700, Christoph Hellwig wrote: > On Fri, Sep 26, 2014 at 12:19:08PM +1000, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > Clean up xlog_recover_process_data() structure in preparation for > > fixing the allocation and freeing context of the transaction being > > recovered. > > > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > > Looks good. The only behavior change I could spot was that we now > validate the length of an ophdr even when starting a new transaction, > which seems sensible. > > Nipick: maybe the lp argument to xlog_recover_process_ophdr should > be called end to make it more obvious? Yes, I had that thought too. I'll change it. > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks! -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs