On Fri, Sep 26, 2014 at 12:19:09PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
>
> The XLOG_UNMOUNT_TRANS case skips the transaction, despite the fact
> an unmount record is always in a standalone transaction. Hence
> whenever we come across one of these we need to free the transaction
> structure associated with it as there is no commit record that
> follows it.
>
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
Looks good,
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> @@ -3600,8 +3605,10 @@ xlog_recover_ophdr_to_trans(
> * on this opheader is allocate a new recovery container to hold
> * the recovery ops that will follow.
> */
> - if (ohead->oh_flags & XLOG_START_TRANS)
> + if (ohead->oh_flags & XLOG_START_TRANS) {
> + ASSERT(be32_to_cpu(ohead->oh_len) == 0);
> xlog_recover_new_tid(rhp, tid, be64_to_cpu(rhead->h_lsn));
> + }
> return NULL;
.. but I suspect this hunk fits better into the previous patch.
Also shouldn't we handle any sort of on disk corruption more gracefully?
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
