On Tue, Sep 09, 2014 at 05:33:30PM -0500, Eric Sandeen wrote: > On 9/9/14 5:28 PM, Christoph Hellwig wrote: > >On Sun, Sep 07, 2014 at 11:41:01AM -0500, Eric Sandeen wrote: > >>process_dinode_int() reports bad flags if > >>dino->di_flags & ~XFS_DIFLAG_ANY - i.e. if > >>any flags are set outside the known set. But > >>then instead of clearing them, it does > >>flags &= ~XFS_DIFLAG_ANY which keeps *only* > >>the bad flags. This leads to persistent, > >>unrepairable errors of the form: > > > >You know you can use up to 75 characters per line for your commit messages, > >don't you? :) > > hah, it's not automated at all, I guess my visual perception > of the window is shrinking. Dave, feel free to fix on commit if > inclined :) I mostly do already - I tend to reflow commit messages to 68 characters (same width I use for email) when I see something like this. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
