On Tue, Aug 26, 2014 at 11:21:37AM +1000, Dave Chinner wrote: > Hi folks, > > The log recovery use-after-free that Brian posted a patch for has > had several previous attempts sent and none have completed review. > So let's put this one to bed for good. > > This patch set addresses the previous review feedback for fixing > this problem. It factors xlog_recover_process_data() to make it > cleaner and isolate the context of the transaction recvoery > structure that is causing problems. It fixes a leak of the structure > in an error condition that I noticed while factoring, as well as the > double free that Brian and others have identified and tried to fix > in the past. It then re-arranges the recovery item management code > to put it all in one place, rather than in 3 separate parts of the > file separated by several hundred lines of unrelated code. > > Comments? > This looks pretty good to me. I like the cleanups and it fixes the problem. A few minor comments/questions to follow. Brian > -Dave. > > _______________________________________________ > xfs mailing list > xfs@xxxxxxxxxxx > http://oss.sgi.com/mailman/listinfo/xfs _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
