On Fri, Aug 15, 2014 at 05:56:08AM -0700, Christoph Hellwig wrote: > On Fri, Aug 15, 2014 at 04:39:07PM +1000, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > xfs_buf_read_uncached() has two failure modes. If can either return > > NULL or bp->b_error != 0 depending on the type of failure, and not > > all callers check for both. Fix it up. > > I'd rather get rid of these annoying calling conventions. Make it > return and errno, and the bp in a pointer argument, with the bp > never non-NULL in case of error. Ok. I considered that, then just did the simple thing. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
