On Thu, Jul 31, 2014 at 10:16:02AM -0700, Christoph Hellwig wrote:
> > int
> > +xfs_swap_extent_flush(
> > + struct xfs_inode *ip)
> > +{
> > + int error;
>
> nipick: shouldn't the arguments and local variables align to the same
> level?
*nod*
> Also a local struct inode variable instead of using VFS_I(ip) 4 times
> would be nice.
Will fix.
> Otherwise looks good,
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Thanks.
-Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
