This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "XFS development tree". The branch, xfs-bulkstat-refactor-NEEDS-FIXING has been created at 1e451aad70915a33111dfcce2c2e1e4582b462a3 (commit) - Log ----------------------------------------------------------------- commit 1e451aad70915a33111dfcce2c2e1e4582b462a3 Author: Jie Liu <jeff.liu@xxxxxxxxxx> Date: Thu Jul 24 18:45:28 2014 +1000 xfs: introduce xfs_bulkstat_ag_ichunk From: Jie Liu <jeff.liu@xxxxxxxxxx> Introduce xfs_bulkstat_ag_ichunk() to process inodes in chunk with a pointer to a formatter function that will iget the inode and fill in the appropriate structure. Refactor xfs_bulkstat() with it. Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx> commit f3d1e587437b784635459dcfccaedd17149282cc Author: Jie Liu <jeff.liu@xxxxxxxxxx> Date: Thu Jul 24 18:42:21 2014 +1000 xfs: introduce xfs_bulkstat_grab_ichunk From: Jie Liu <jeff.liu@xxxxxxxxxx> Introduce xfs_bulkstat_grab_ichunk() to look up an inode chunk in where the given inode resides, then grab the record. Update the data for the pointed-to record if the inode was not the last in the chunk and there are some left allocated, return the grabbed inode count on success. Refactor xfs_bulkstat() with it. Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx> commit 4b8fdfecd84528e044a6ca32242de641b203995b Author: Jie Liu <jeff.liu@xxxxxxxxxx> Date: Thu Jul 24 18:41:18 2014 +1000 xfs: introduce xfs_bulkstat_ichunk_ra From: Jie Liu <jeff.liu@xxxxxxxxxx> Introduce xfs_bulkstat_ichunk_ra() to loop over all clusters in the next inode chunk, then performs readahead if there are any allocated inodes in that cluster. Refactor xfs_bulkstat() with it. Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> Reviewed-by: Christoph Hellwig <hch@xxxxxx> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx> commit d4c27348751bffeb57d87fc631f76716e3036c6d Author: Jie Liu <jeff.liu@xxxxxxxxxx> Date: Thu Jul 24 18:40:43 2014 +1000 xfs: fix error handling at xfs_bulkstat From: Jie Liu <jeff.liu@xxxxxxxxxx> We should not ignore the btree operation errors at xfs_bulkstat() but to propagate them if any. This patch fix two places in this function and the remaining things will be fixed with code refactoring thereafter. Signed-off-by: Christoph Hellwig <hch@xxxxxx> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx> commit 296dfd7fdba3a8b702d9cb47afc9061f52e18656 Author: Jie Liu <jeff.liu@xxxxxxxxxx> Date: Thu Jul 24 18:40:26 2014 +1000 xfs: remove redundant user buffer count checks at xfs_bulkstat From: Jie Liu <jeff.liu@xxxxxxxxxx> Remove the redundant user buffer and count checks as it has already been validated at xfs_ioc_bulkstat(). Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx> commit c7cb51dcb0a38624d42eeabb38502fa54a4d774b Author: Jie Liu <jeff.liu@xxxxxxxxxx> Date: Thu Jul 24 12:18:47 2014 +1000 xfs: fix error handling at xfs_inumbers From: Jie Liu <jeff.liu@xxxxxxxxxx> To fetch the file system number tables, we currently just ignore the errors and proceed to loop over the next AG or bump agino to the next chunk in case of btree operations failed, that is not properly because those errors might hint us potential file system problems. This patch rework xfs_inumbers() to handle the btree operation errors as well as the loop conditions. Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx> commit 549fa00679dd14beaaa685486549c637e8e02182 Author: Jie Liu <jeff.liu@xxxxxxxxxx> Date: Thu Jul 24 12:11:47 2014 +1000 xfs: consolidate xfs_inumbers From: Jie Liu <jeff.liu@xxxxxxxxxx> Consolidate xfs_inumbers() to make the formatter function return correct error and make the source code looks a bit neat. Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx> commit d716f8eedb143387afd35d337327090b8348159e Author: Christoph Hellwig <hch@xxxxxx> Date: Thu Jul 24 12:07:15 2014 +1000 xfs: remove xfs_bulkstat_single From: Christoph Hellwig <hch@xxxxxx> xfs_bukstat_one doesn't have any failure case that would go away when called through xfs_bulkstat, so remove the fallback and the now unessecary xfs_bulkstat_single function. Signed-off-by: Christoph Hellwig <hch@xxxxxx> Reviewed-by: Jie Liu <jeff.liu@xxxxxxxxxx> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx> commit 8fe657760d5c8372cd4cf022c4cdb9307a3af995 Author: Jie Liu <jeff.liu@xxxxxxxxxx> Date: Thu Jul 24 11:33:28 2014 +1000 xfs: remove redundant stat assignment in xfs_bulkstat_one_int From: Jie Liu <jeff.liu@xxxxxxxxxx> Remove the redundant BULKSTAT_RV_NOTHING assignment in case of call xfs_iget() failed at xfs_bulkstat_one_int(). Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> Reviewed-by: Christoph Hellwig <hch@xxxxxx> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx> ----------------------------------------------------------------------- hooks/post-receive -- XFS development tree _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs