Re: [PATCH] xfs: fix uflags detection at xfs_fs_rm_xquota

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/15/14, 4:35 AM, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> We are intended to check up uflags against FS_PROJ_QUOTA rather than 
> FS_USER_UQUOTA once more, it looks to me like a typo, but might cause
> the project quota metadata space can not be removed.

Ugh, mea culpa.  Thanks for spotting.  :(

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Thankfully I don't think anyone uses this interface ;)

> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_quotaops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_quotaops.c b/fs/xfs/xfs_quotaops.c
> index 4f7aecb..b238027 100644
> --- a/fs/xfs/xfs_quotaops.c
> +++ b/fs/xfs/xfs_quotaops.c
> @@ -123,7 +123,7 @@ xfs_fs_rm_xquota(
>  		flags |= XFS_DQ_USER;
>  	if (uflags & FS_GROUP_QUOTA)
>  		flags |= XFS_DQ_GROUP;
> -	if (uflags & FS_USER_QUOTA)
> +	if (uflags & FS_PROJ_QUOTA)
>  		flags |= XFS_DQ_PROJ;
>  
>  	return xfs_qm_scall_trunc_qfiles(mp, flags);
> 

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux