On Mon, Jul 14, 2014 at 04:45:00PM +0200, Jan Kara wrote: > Currently xfs_logprint doesn't show detailed data about AGF buffers and > instead always shows "Out of space". This is because xfs_agf_t has > additional fields and padding which we never read from disk and thus > buffer length is always smaller than the size of xfs_agf_t. > > Fix the problem by only making sure we have enough data in the buffer > to contain all the information we want to print. The fix looks correct to me, but te explanation should be more verbose: the reason why we don't read agf_uuid and above is because you're probably dumping a v4 filesystems which doesn't even have those fields. Its seems like various other fields have the same issue in logprint, and I also suspect we want some defines for the v4 size instead of using the offsetoff tricks. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
