> > On Tue, Jul 08, 2014 at 08:59:49PM +0900, Namjae Jeon wrote: > > This patch implements fs ioctl's IOC_MOV_DATA for XFS. > > Shouldn't this share code with the XFS_IOC_SWAPEXT implementation? Lukas has raised the same question for ext4. Both xfs(XFS_IOC_SWAPEXT) and ext4(EXT4_IOC_MOVE_EXT) has ioctls which uses almost similar kind of structure as struct mov_data. As such, there seems to be possiblity for sharing basic code (I will try) used for sanity checking in IOC_MOV_DATA to be shared with these ioctls but the core functionality code will remain different. Thanks! _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
