Re: [PATCH 3/6] repair: handle directory block corruption in phase 6

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> @@ -2179,7 +2179,7 @@ longform_dir2_entry_check(xfs_mount_t	*mp,
>  	freetab = malloc(FREETAB_SIZE(ip->i_d.di_size / mp->m_dirblksize));
>  	if (!freetab) {
>  		do_error(
> -		_("malloc failed in longform_dir2_entry_check (%" PRId64 " bytes)\n"),
> +_("malloc failed in longform_dir2_entry_check (%" PRId64 " bytes)\n"),

Use __func__ to make this both more readable and future proof (same for
the other error message).


Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux