On Sat 14-06-14 09:56:22, Dave Chinner wrote: > On Fri, Jun 13, 2014 at 05:02:07PM +0200, Jan Kara wrote: > > On Wed 04-06-14 14:44:40, Brian Foster wrote: > > > On Wed, Jun 04, 2014 at 06:53:53PM +0200, Jan Kara wrote: > > > > Rounding in xfs_alloc_fix_len() is wrong. As the comment states, the > > > > result should be a number of a form (k*prod+mod) however due to sign > > > > mistake the result is different. As a result allocations on raid arrays > > > > could be misaligned in some cases. > > > > > > > > This also seems to fix occasional assertion failure: > > > > XFS_WANT_CORRUPTED_GOTO(rlen <= flen, error0) > > > > in xfs_alloc_ag_vextent_size(). > > > > > > > > Also add an assertion that the result of xfs_alloc_fix_len() is of > > > > expected form. > > > > > > > > Signed-off-by: Jan Kara <jack@xxxxxxx> > > > > --- > > > > > > Looks good to me. Thanks Jan. > > > > > > Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx> > > Ping Dave? Are you going to pick up this patch? > > I did - it's already in Linus' tree for 3.16: > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/fs/xfs/xfs_alloc.c?id=30265117ee1e23fa91920f337a3ea91207f700dc Ah, sorry. I was expecting some email about acceptance. I'll check the git tree next time. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
