On Fri, Jun 06, 2014 at 04:03:10PM -0500, Eric Sandeen wrote:
> Ensure that the string we read from leftofffile is NULL
> terminated; the buffer gets passed to strchr(), so
> it's important that we ensure it ends with NULL.
>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
>
> diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c
> index 3818f02..94d235c 100644
> --- a/fsr/xfs_fsr.c
> +++ b/fsr/xfs_fsr.c
> @@ -554,6 +554,8 @@ fsrallfs(char *mtab, int howlong, char *leftofffile)
> fsrprintf(_("could not read %s, starting with %s\n"),
> leftofffile, *fs->dev);
> } else {
> + /* Ensure the buffer we read is null terminated */
> + buf[SMBUFSZ-1] = '\0';
Maybe just initialize the buffer..?
Brian
> for (fs = fsbase; fs < fsend; fs++) {
> fsname = fs->dev;
> if ((strncmp(buf,fsname,strlen(fsname)) == 0)
>
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
