Dave Chinner <david@xxxxxxxxxxxxx> writes:
> It is my pleasure to announce the release of v3.2.0 of the xfsprogs
> package.
If this is built with DEBUG= (i.e. not defaulting to DEBUG=-NDEBUG),
several source files fail to compile -- it looks like there are a number
of assertions that haven't been updated for changes in the code:
logitem.c:53:24: error: 'struct xfs_buf' has no member named 'b_map_count'
ASSERT(blip->bli_buf->b_map_count == nmaps);
^
trans.c:52:12: error: 'struct xfs_log_item' has no member named 'li_ailp'
ASSERT(lip->li_ailp == tp->t_mountp->m_ail);
^
trans.c:52:37: error: 'xfs_mount_t' has no member named 'm_ail'
ASSERT(lip->li_ailp == tp->t_mountp->m_ail);
^
util.c:253:40: error: 'mp' undeclared (first use in this function)
ASSERT(uuid_equal(&ip->i_d.di_uuid, &mp->m_sb.sb_uuid));
^
util.c:401:33: error: 'xfs_ifork_t' has no member named 'if_ext_max'
ip->i_d.di_nextents > ip->i_df.if_ext_max);
^
xfs_btree.c:545:2: warning: implicit declaration of function 'xfs_buf_geterror' [-Wimplicit-function-declaration]
ASSERT(!xfs_buf_geterror(bp));
^
xfs_btree.c:2052:21: error: 'const struct xfs_btree_ops' has no member named 'keys_inorder'
ASSERT(cur->bc_ops->keys_inorder(cur,
^
xfs_btree.c:2064:21: error: 'const struct xfs_btree_ops' has no member named 'recs_inorder'
ASSERT(cur->bc_ops->recs_inorder(cur,
^
xfs_btree.c:2240:21: error: 'const struct xfs_btree_ops' has no member named 'keys_inorder'
ASSERT(cur->bc_ops->keys_inorder(cur, rkp,
^
xfs_btree.c:2259:21: error: 'const struct xfs_btree_ops' has no member named 'recs_inorder'
ASSERT(cur->bc_ops->recs_inorder(cur, rrp,
^
xfs_dir2_node.c:1053:36: error: 'oldstale' undeclared (first use in this function)
ASSERT(hdr1.stale + hdr2.stale == oldstale);
^
xfs_inode_fork.c:728:2: warning: implicit declaration of function 'xfs_isilocked' [-Wimplicit-function-declaration]
ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL|XFS_ILOCK_SHARED));
^
xfs_inode_fork.c:728:42: error: 'XFS_ILOCK_SHARED' undeclared (first use in this function)
ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL|XFS_ILOCK_SHARED));
^
(Errors from current Git, built with GCC 4.9. You also get a good crop
of warnings if you build it with clang 3.4.1's scan-build, which'd be
worth checking out in case there's anything serious there.)
> A signed gzipped-tar archive of the source code is available here:
It's signed with a different key from the previous release -- it'd be
useful to mention the key ID in the announcement so that it can be
verified.
Cheers,
--
Adam Sampson <ats@xxxxxxxxx> <http://offog.org/>
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
