On Thu, May 08, 2014 at 09:45:20AM -0400, Brian Foster wrote: > On Thu, May 08, 2014 at 05:54:05AM -0700, Christoph Hellwig wrote: > > On Thu, May 08, 2014 at 08:02:28AM -0400, Brian Foster wrote: > > > Missing a $ here... > > > > > > Adding that, the single threaded build still breaks for me. E.g., > > > > > > - rm -rf fs/xfs > > > - git checkout -- . > > > - make > > > > The kernel build systems doesn't support building a single module from > > multiple makefiles. Take a look how to handle a subdirectory in the > > older XFS versions that still had that linux-2.6 subdirectory, it just > > pulls the files in the subdirectory in from the main makefile, which > > requires some tiny hacks for the include path. > > > > Good point, I was looking around for some example of this and didn't see > anything obvious, but didn't think to look back to that. Indeed it does > just reference the files in the subdirectory... thanks. I haven't looked at that, but I'm assuming that it is just a -include libxfs/Makefile directive rather than using: obj-y += libxfs/ If that's all it takes, then I'll rebase the patch on that.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
