On Tue, May 06, 2014 at 01:15:18AM -0700, Christoph Hellwig wrote: > > > > @@ -1112,7 +1085,7 @@ xfs_bumplink( > > * system to do this, then we need to bump the superblock > > * version number as well. > > */ > > - xfs_bump_ino_vers2(tp, ip); > > + xfs_bump_ino_vers2(ip); > > The comment here is certainly out of date now. > > But I think keeping these xfs_bump_ino_vers2 calls around everywhere is > wrong to start with. xfs_iread should make sure all inodes are version > 1, that allows to kill xfs_bump_ino_vers2 entirely, and probably also > simplify xfs_ialloc a little more. At the point we won't have to deal > with v1 inodes anywhere but in xfs_iread, and we can have a big fat > comment in that place why we even bother with the v1 inodes, because > the fact that we have the hasnlink bit but inodes might still be old > format is something we'll all have forgotten about in a few years, > and new developers will never figure out by themselves. OK, I'll look at reworking it aong those lines. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
