Re: [PATCH 3/6] xfsprogs: get rid of XFS_IALLOC_BLOCKS macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/06 2014 05:10 AM, Brian Foster wrote:
> On Mon, May 05, 2014 at 08:32:13PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@xxxxxxxxxx>
>>
>> Get rid of XFS_IALLOC_BLOCKS() macros, use mp->m_ialloc_blks directly.
>>
>> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
>> ---
>>  db/check.c                |  2 +-
>>  db/frag.c                 |  2 +-
>>  db/metadump.c             |  2 +-
>>  include/xfs_ialloc.h      |  5 -----
>>  include/xfs_trans_space.h |  2 +-
>>  libxfs/xfs_ialloc.c       |  8 ++++----
>>  libxfs/xfs_trans_resv.c   |  8 ++++----
>>  mkfs/proto.c              |  2 +-
>>  repair/dino_chunks.c      | 24 ++++++++++++------------
>>  repair/prefetch.c         |  2 +-
>>  repair/xfs_repair.c       |  4 ++--
>>  11 files changed, 28 insertions(+), 33 deletions(-)
>>
<snip>

>> diff --git a/mkfs/proto.c b/mkfs/proto.c
>> index 5a47e27..2689f75 100644
>> --- a/mkfs/proto.c
>> +++ b/mkfs/proto.c
>> @@ -39,7 +39,7 @@ static long filesize(int fd);
>>   * (basically no fragmentation).
>>   */
>>  #define	MKFS_BLOCKRES_INODE	\
>> -	((uint)(XFS_IALLOC_BLOCKS(mp) + ((mp)->m_in_maxlevels - 1)))
>> +	((uint)(mp->m_ialloc_blks + ((mp)->m_in_maxlevels - 1)))
> Nit:		(mp) 
> 
> Probably not necessary here anyways...

Nice catch, thanks for your review.


Cheers,
-Jeff

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux