On Fri, May 02, 2014 at 08:39:39AM +1000, Dave Chinner wrote: > This issue with xfs_setattr_size() was introduced back in 2010 by > commit fa9b227 ("xfs: new truncate sequence") which moved the page > cache truncate from outside the transaction context (what was > xfs_itruncate_data()) to inside the transaction context as a call to > truncate_setsize(). And it was moved because we should only call truncate_setsize once the truncate can't fail any more. So to move it out of transaction context it needs to move after the commit of the transaction(s). _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs