On Mon, Apr 14, 2014 at 12:30:20PM +1000, Dave Chinner wrote: > IOWs, XFS is returning EEXIST rather than ENOTEMPTY for several of > these rename tests. The rename man page says this about the errors: > > ENOTEMPTY or EEXIST > newpath is a nonempty directory, that is, contains > entries other than "." and "..". > > Which implies that both errors are valid and so the test should pass > in either case. Can you send a patch to handle these > different-but-valid error returns? I would much prefer if all Linux filesystems behaved uniformly here. While EEXIST sounds much more logical to me in this case I suspect most other filesystems have copy & pasted from ext2, and we should switch to ENOTEMPTY as well. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
