On Mon, Apr 14, 2014 at 11:55:44AM +1000, Dave Chinner wrote: > > +static void > > +xfs_bmap_fix_args( > > + struct xfs_bmalloca *ap, > > + struct xfs_alloc_arg *args, > > + xfs_extlen_t *blen, > > + int notinit) > > Not a big fan of the "fix_args" name here. What it's actually doing > is setting the minimum allocation length. Also, it could return the > minimum length rather than set it inside the function, and pass > blen by value rather than reference as it isn't modified in the > function... Sure. A any good suggestion for a name? _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs