On Thu, Apr 10, 2014 at 11:55:37AM +0200, Lukas Czerner wrote: > Currently there is a problem with parse_config_section() when the > configuration value contains equality sign like this for example: > > MOUNT_OPTIONS="-o data=journal" > > the result will be > > export MOUNT_OPTIONS="-o data="journal" > > which is not going to work. The reason is that the expression used to > parse the configuration options uses greedy matching '.*'. Fix this by > using non greedy expression to match the first equality sign '[^=]'. > > Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx> Looks fine. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> It would probably be a good idea to comment what the sed line noise is actually doing, so it's easier to understand in future... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
