On Wed, Apr 09, 2014 at 03:21:50PM -0400, Brian Foster wrote: > xfs_vn_tmpfile() also fails to initialize security or default acls on > the newly created inode. Which it doesn't have to, as it is never available in the filesystem namespace. > The d_tmpfile() call is removed from xfs_create_tmpfile() and pulled up > into the new handler to address the deadlock. E.g., xfs_create_tmpfile() > has committed the create transaction and unlocked the inode prior to > mapping the inode to the dentry. This part of the patch looks sane, although the window where the XFS inode and VFS inode i_nlink are out of sync worries me a little. I don't think the other refactoring belongs into the same patch. If we decide that we want it please avoid the useless ACL inheritance for tmpfiles. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
