Re: [PATCH 1/2] xfsdump: getdents.c: clean up ifdef-hell around sys_getdents

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 08, 2014 at 10:33:11AM +1000, Dave Chinner wrote:
> On Mon, Mar 24, 2014 at 02:19:07PM -0400, Kyle McMartin wrote:
> > Remove the ifdef-hell imported from glibc around getdents64. Everything
> > since 2.4.1 supports things properly and this seems like a sensible
> > clean up, so lets just assume it exists and handle it by falling back
> > if not.
> > 
> > Additionally, if the old getdents syscall doesn't exist, just stub out
> > the actual syscall and return ENOSYS.
> > 
> > ---
> 
> Kyle, these two patches are missing your SOB. I'm going to assume
> you wrote this yourself (given the history, it's a fair bet :)
> and add them in - let me know if then assumption is wrong so I can
> correct it.

That's correct, my apologies for not including it on the submission.

Thanks very much Dave.

--Kyle

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux