On Mon, Mar 31, 2014 at 10:37:11PM -0400, Theodore Ts'o wrote: > On Mon, Mar 31, 2014 at 01:51:48PM +1100, Dave Chinner wrote: > > > especially given that based on a challenge which > > > Greg K-H gave us at the kernel pannel at Collab Summit, > > ^^^^ > > > > Hmmmm. Not the way I remember it. Perhaps I should go look at the > > video and check that Greg was addressing me directly as the xfstests > > maintainer with those comments. After all, those lights on stage can > > be blinding..... > > Sorry, I thought in the discussions we had afterwards you agreed with > me that *some* way of running xfststs easily was going to be a > requirement, as it is somewhat doubtful that most non-file system > developers will have the patience to deal with the "some assembly > required" in order to actually run xfstests, and actually putting > xfstests into the kernel sources wasn't going to be particularly > useful unless we have some way of making it possible to run the tests > in a semi-automated fashion. Right, there was follup discussion about how we could potentially acheive what Greg wanted, but it was more of a "we've got pieces that we might be able to leverage" discussion than anything else. > Whether that method is based on what I have in xfstests-bld, or some > other way is I agree certainly up for discussion. At the moment the > system I have is only set up for ext4, although I will happily accept > patches and work with other file system developers to enhance it so it > can work with other file systems. Right, that's pretty much where we finished the discussion at the collab summit ;) But that this is why I responded to your previous email - while you likely had the best of intentions, you gave the impression that xfstests-bld type of solution was fait accompli, when in fact we haven't even really started defining the problem space and gathering requirements yet... > And of course, whether changes in the mainline kernel tree are > manually propagated changes from the xfstests.git tree, or whether > primary development happens in the kernel tree, is ultimately going to > be up to you and the XFS developers who have stewardship of xfstests. > I'm not sure I would be that excited about manual propagation of > changes from one git tree to another, but that is of course, up to > you. And this is exactly my point, Ted. Again, you are presuming that the implementation is going to require syncing commits across disparate git trees and other such games will be needed to maintain separate packages. Nothing could be further from the truth: we already have this problem with the shared XFS kernel/userspace code and it's a royal PITA keeping them in sync. Hence introducing the same maintenance problem with new code and infrastructure is highly undesirable and something we'll try to avoid at all costs. Basically, we need to start with a proposal that outlines what we need in the kernel tree for testing filesystems in place and go from there. Once we've agreed on the big picture stuff and solved the maintenance, packaging and "how do we run in place" architectural issues, then we can start working on the implementation. I'm hoping to write something up in the next week or two to being the process and discussions, because I'm sure the -stable folk will have some input on what they would like to be able to do.... :) Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
