On Fri, Mar 28, 2014 at 11:03:13AM +0300, Dan Carpenter wrote:
> There were some extra semi-colons here which mean that we return true
> unintentionally.
>
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index 98016b3..75df77d 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -659,10 +659,10 @@ xfs_check_page_type(
> if (type == XFS_IO_UNWRITTEN)
> return true;
> } else if (buffer_delay(bh)) {
> - if (type == XFS_IO_DELALLOC);
> + if (type == XFS_IO_DELALLOC)
> return true;
> } else if (buffer_dirty(bh) && buffer_mapped(bh)) {
> - if (type == XFS_IO_OVERWRITE);
> + if (type == XFS_IO_OVERWRITE)
> return true;
> }
>
Nice catch.
Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>
>
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
