On Tue, Mar 25, 2014 at 08:34:22AM -0700, Christoph Hellwig wrote: > On Tue, Mar 25, 2014 at 10:15:55AM -0400, Brian Foster wrote: > > I wonder if we could clean up the d_name offset checks to check it once > > and use a flag. Or use a signed type for size_diff and trigger off that. > > Just a thought, fwiw. > > I'd just leave the code as-is and just remove the ifdef cruft. If > anyone is motivated enough to do real work on this area the callers > should simply be switched to readdir(3) and friends instead of > bikeshedding the current cruft. I just don't want to put even more load > on Kyle how just wants to get xfsdump running on arm64.. > Heh, actually, I started doing exactly that last night, after looking at all the getdents_wrap callers... That's probably a bit more... error-sensitive patch though, so I'd prefer if at least 1/2 and/or 2/2 went in separately for debuggability. --Kyle _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
