On 3/18/14, 11:39 AM, Eryu Guan wrote:
> Command xfs_quota -xc "report -h" /nosuchdir would get segfault, fix
> that by checking fs_path first before dereferencing it.
>
> Cc: Eric Sandeen <esandeen@xxxxxxxxxx>
> Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx>
> ---
> quota/report.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/quota/report.c b/quota/report.c
> index 70894a2..d486524 100644
> --- a/quota/report.c
> +++ b/quota/report.c
> @@ -624,7 +624,7 @@ report_f(
> if (flags & ALL_MOUNTS_FLAG)
> report_any_type(fp, form, type, NULL,
> lower, upper, flags);
> - else if (fs_path->fs_flags & FS_MOUNT_POINT)
> + else if (fs_path && fs_path->fs_flags & FS_MOUNT_POINT)
> report_any_type(fp, form, type, fs_path->fs_dir,
> lower, upper, flags);
> } else while (argc > optind) {
>
I think this is ok; state_f does the same thing.
but others don't; enable_f, disable_f, off_f etc.
Also this seems to be a slight regression since v3.1.8 or so, let me double
check that and see if we need to fix something more general.
Thanks!
-Eric
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
