Re: [PATCH V2] xfstests: fix error msg in aio-dio-subblock-eof-read.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 03, 2014 at 11:43:56PM -0600, Eric Sandeen wrote:
> io_getevents returns the number of events; printing its
> return as "bytes read" is ... wrong.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> V2: print as signed so we can easily see errors returned
> 

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

> diff --git a/src/aio-dio-regress/aio-dio-subblock-eof-read.c b/src/aio-dio-regress/aio-dio-subblock-eof-read.c
> index a48841d..8f74cec 100644
> --- a/src/aio-dio-regress/aio-dio-subblock-eof-read.c
> +++ b/src/aio-dio-regress/aio-dio-subblock-eof-read.c
> @@ -105,8 +107,8 @@ main(int argc, char **argv)
>  	 *  are broken, we may very well see a result of 4k.
>  	 */
>  	if (ie.res != FILE_SIZE)
> -		fail("AIO read of last block in file returned %d bytes, "
> -		     "expected %d\n", ret, FILE_SIZE);
> +		fail("AIO read of last block in file returned %ld bytes, "
> +		     "expected %d\n", ie.res, FILE_SIZE);
>  
>  	printf("AIO read of last block in file succeeded.\n");
>  	return 0;
> 
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux