On Mon, Mar 03, 2014 at 04:58:44PM -0600, Eric Sandeen wrote: > Commit "3a19fb7 libxfs: stop caching inode structures" > introduced a use after free. > > libxfs_iput() already does the check for ip->i_itemp, and a > kmem_zone_free() if it's present, and then frees the ip pointer. > Re-checking ip->i_itemp after the libxfs_iput call will access > the freed ip pointer, as will setting ip_>i_itemp to NULL. > > Simply remove the offending code to fix this up. > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > --- > > V2: Make it prettier based on Dave's comments. looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
