This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".
The branch, for-next has been updated
14e637c Merge branch 'xfs-verifier-cleanup' into for-next
181d1a1 Merge branch 'xfs-stack-fixes' into for-next
93a8614 xfs: fix directory inode iolock lockdep false positive
a1358aa xfs: allocate xfs_da_args to reduce stack footprint
f876e44 xfs: always do log forces via the workqueue
ce5028c xfs: modify verifiers to differentiate CRC from other errors
db9355c xfs: print useful caller information in xfs_error_report
ca23f8f xfs: add xfs_verifier_error()
f1dbcd7 xfs: add helper for updating checksums on xfs_bufs
5158217 xfs: add helper for verifying checksums on xfs_bufs
533b81c xfs: Use defines for CRC offsets in all cases
e0d2c23 xfs: skip pointless CRC updates after verifier failures
from f13780692e659df3623461ca5398b66739a6c56f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 14e637ca53fa257cbff7f73981dd87c457a6be1e
Merge: 181d1a1 ce5028c
Author: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu Feb 27 16:53:00 2014 +1100
Merge branch 'xfs-verifier-cleanup' into for-next
commit 181d1a1134f5d4924c307ea90708e55c80eaf3b0
Merge: f137806 93a8614
Author: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu Feb 27 16:52:44 2014 +1100
Merge branch 'xfs-stack-fixes' into for-next
commit ce5028cfe3ca48695b6a128638fe224426d37ebe
Author: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu Feb 27 15:23:10 2014 +1100
xfs: modify verifiers to differentiate CRC from other errors
Modify all read & write verifiers to differentiate
between CRC errors and other inconsistencies.
This sets the appropriate error number on bp->b_error,
and then calls xfs_verifier_error() if something went
wrong. That function will issue the appropriate message
to the user.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>
Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
commit db9355c296eb71271bb3807ad4a9d43f6b3c35d3
Author: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Thu Feb 27 15:21:37 2014 +1100
xfs: print useful caller information in xfs_error_report
xfs_error_report used to just print the hex address of the caller;
%pF will give us something more human-readable.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
Reviewed-by: Jie Liu <jeff.liu@xxxxxxxxxx>
Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
commit ca23f8fdd6a0dd37b3909ce7709c491f0c26399d
Author: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu Feb 27 15:21:07 2014 +1100
xfs: add xfs_verifier_error()
We want to distinguish between corruption, CRC errors,
etc. In addition, the full stack trace on verifier errors
seems less than helpful; it looks more like an oops than
corruption.
Create a new function to specifically alert the user to
verifier errors, which can differentiate between
EFSCORRUPTED and CRC mismatches. It doesn't dump stack
unless the xfs error level is turned up high.
Define a new error message (EFSBADCRC) to clearly identify
CRC errors. (Defined to EBADMSG, bad message)
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
commit f1dbcd7e38c80c2165516b4432231b46f1adc76c
Author: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Thu Feb 27 15:18:23 2014 +1100
xfs: add helper for updating checksums on xfs_bufs
Many/most callers of xfs_update_cksum() pass bp->b_addr and
BBTOB(bp->b_length) as the first 2 args. Add a helper
which can just accept the bp and the crc offset, and work
it out on its own, for brevity.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
commit 5158217058fc2cdb92e05b9bb3c1a350d2a51ed9
Author: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Thu Feb 27 15:17:27 2014 +1100
xfs: add helper for verifying checksums on xfs_bufs
Many/most callers of xfs_verify_cksum() pass bp->b_addr and
BBTOB(bp->b_length) as the first 2 args. Add a helper
which can just accept the bp and the crc offset, and work
it out on its own, for brevity.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
commit 533b81c875589ad0a2fc116991534b4601195253
Author: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Thu Feb 27 15:15:27 2014 +1100
xfs: Use defines for CRC offsets in all cases
Some calls to crc functions used useful #defines,
others used awkward offsetof() constructs.
Switch them all to #define to make things a bit cleaner.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
commit e0d2c23a253149b4f8a6100f94ca62ddc4b2ae84
Author: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Thu Feb 27 15:14:31 2014 +1100
xfs: skip pointless CRC updates after verifier failures
Most write verifiers don't update CRCs after the verifier
has failed and the buffer has been marked in error. These
two didn't, but should.
Add returns to the verifier failure block, since the buffer
won't be written anyway.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
Reviewed-by: Jie Liu <jeff.liu@xxxxxxxxxx>
Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
-----------------------------------------------------------------------
Summary of changes:
fs/xfs/xfs_ag.h | 6 +
fs/xfs/xfs_alloc.c | 45 +++---
fs/xfs/xfs_alloc_btree.c | 16 ++-
fs/xfs/xfs_attr_leaf.c | 17 +--
fs/xfs/xfs_attr_remote.c | 15 +-
fs/xfs/xfs_bmap_btree.c | 16 +--
fs/xfs/xfs_btree.c | 14 +-
fs/xfs/xfs_buf.h | 14 ++
fs/xfs/xfs_da_btree.c | 17 +--
fs/xfs/xfs_dinode.h | 2 +
fs/xfs/xfs_dir2.c | 342 +++++++++++++++++++++++++++-----------------
fs/xfs/xfs_dir2_block.c | 17 +--
fs/xfs/xfs_dir2_data.c | 20 +--
fs/xfs/xfs_dir2_leaf.c | 17 +--
fs/xfs/xfs_dir2_node.c | 17 +--
fs/xfs/xfs_dquot_buf.c | 11 +-
fs/xfs/xfs_error.c | 27 +++-
fs/xfs/xfs_error.h | 1 +
fs/xfs/xfs_format.h | 2 +
fs/xfs/xfs_ialloc.c | 24 ++--
fs/xfs/xfs_ialloc_btree.c | 16 ++-
fs/xfs/xfs_inode_buf.c | 7 +-
fs/xfs/xfs_iops.c | 14 ++
fs/xfs/xfs_linux.h | 2 +
fs/xfs/xfs_log_cil.c | 52 +++++--
fs/xfs/xfs_sb.c | 16 +--
fs/xfs/xfs_sb.h | 2 +
fs/xfs/xfs_symlink_remote.c | 16 +--
28 files changed, 467 insertions(+), 298 deletions(-)
hooks/post-receive
--
XFS development tree
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
