Re: [PATCH] xfs_io: add fzero command for zeroing range via fallocate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 25, 2014 at 08:15:33PM +0100, Lukas Czerner wrote:
> Add fzero command which zeroes a range of the file using
> fallocate FALLOC_FL_ZERO_RANGE flag.
> 
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>

Looks ok, but...

> @@ -312,7 +342,17 @@ prealloc_init(void)
>  	fcollapse_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK;
>  	fcollapse_cmd.args = _("off len");
>  	fcollapse_cmd.oneline =
> -	_("de-allocates space and eliminates the hole by shifting extents");
> +		_("de-allocates space and eliminates the hole by shifting extents");
>  	add_command(&fcollapse_cmd);

I'll drop this change because it pushes the line beyond 80
characters....

Otherwise,

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux