On Wed, Feb 26, 2014 at 07:13:25PM -0600, Eric Sandeen wrote: > xfs_logprint recognizes a "left over region from split log item" > but then expects the *next* op to be a valid start to a new > item. The problem is, we can split i.e. an xfs_inode_log_format > item, skip over it, and then land on the xfs_icdinode_t > data which follows it - this doesn't have a valid log item > magic (XFS_LI_*) and we error out. This results in something > like: > > xfs_logprint: unknown log operation type (494e) > > Fix this by recognizing that we've skipped over an item and > lost the context we're in, so just continue skipping over > op headers until we find the next valid start to a log item. > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> Looks good - fixes the problem and does a good job of explaining it. :) Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
