On Tue, Feb 25, 2014 at 05:54:32PM -0800, Christoph Hellwig wrote: > On Wed, Feb 26, 2014 at 10:43:57AM +1100, Dave Chinner wrote: > > On Tue, Feb 25, 2014 at 12:05:58PM -0800, Christoph Hellwig wrote: > > > So what's protecting the cache hits statistics now? > > > > Nothing. And I don't care because the statistic is meaningless from > > the point of view of tuning xfs_repair performance. > > In that case I think it's better to just remove c_hits instead of > updating it in a racy way. I didn't say it's completely meaningless - it's handy for debugging, just not useful to end users and so accuracy isn't important enough to use a global lock on. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
