On 2/9/14, 9:33 PM, Dave Chinner wrote: > On Sun, Feb 09, 2014 at 08:29:47PM -0600, Eric Sandeen wrote: >> Many/most callers of xfs_update_cksum() pass bp->b_addr and >> BBTOB(bp->b_length) as the first 2 args. Add a helper >> which can just accept the bp and the crc offset, and work >> it out on its own, for brevity. > > The title of the patch is the same as the previous one - I think you > forgot to "update" it? Bah, yes. Probably doesn't really even have to be 2 patches. > Other than that, same comments as for the previous patch. ok, thx for the reviews. Agree that the defines make it better. -Eric > Cheers, > > Dave. > _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
