Failures were reported in xfs/008 on s390; dchinner suggested that perhaps the uninitialized "valid" bitmap was behaving differently on that platform, and sure enough, this patch fixes things up. TBH, I'm not sure why using an uninitialized bitmap worked at all, ever, anywhere...? Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> --- diff --git a/src/randholes.c b/src/randholes.c index 5ad602e..ee5b6b6 100644 --- a/src/randholes.c +++ b/src/randholes.c @@ -437,6 +437,7 @@ main(int argc, char *argv[]) perror("malloc"); return 1; } + memset(valid, 0, size); /* Lots of arguments affect how we open the file */ oflags = test ? O_RDONLY : O_RDWR|O_CREAT; _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs