On Mon, Jan 20, 2014 at 5:55 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Sun, Jan 19, 2014 at 05:13:35AM +0000, Al Viro wrote:
>> Folks, what do you think about the following:
>
> That's very much what Shaggy did in the aio-direct tree, except that
> it kept using a single set of methods. Linus really didn't like it
> unfortunately.
Umm. That wasn't what I objected to.
I objected to the incredibly ugly implementation, the crazy new flags
arguments for core helper functions, ugly naming etc etc. I even
outlined what might fix it.
In other words, I thought the code was shit and ugly. Not that
iterators per se would be wrong. Just doing them badly is wrong.
So don't go putting words in my mouth. It isn't "unfortunate" at all
that I have higher quality standards.
Linus
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
