On Tue, Jan 07, 2014 at 07:21:05PM +0800, Jeff Liu wrote: > Hi Chuansheng, > > On 01/07 2014 16:53 PM, Chuansheng Liu wrote: > > > > In case CONFIG_DEBUG_OBJECTS_WORK is defined, it is needed to > > call destroy_work_on_stack() which frees the debug object to pair > > with INIT_WORK_ONSTACK(). > > > > Signed-off-by: Liu, Chuansheng <chuansheng.liu@xxxxxxxxx> > > --- > > fs/xfs/xfs_bmap_util.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c > > index 1394106..82e0dab 100644 > > --- a/fs/xfs/xfs_bmap_util.c > > +++ b/fs/xfs/xfs_bmap_util.c > > @@ -287,6 +287,7 @@ xfs_bmapi_allocate( > > INIT_WORK_ONSTACK(&args->work, xfs_bmapi_allocate_worker); > > queue_work(xfs_alloc_wq, &args->work); > > wait_for_completion(&done); > > + destroy_work_on_stack(&args->work); > > return args->result; > > } > > Thanks for your patch and it work fine for my testing. I missed this in an > old commit: [ 3b876c8f2a xfs: fix debug_object WARN at xfs_alloc_vextent() ] Looks good to me too. Reviewed-by: Ben Myers <bpm@xxxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
