Re: [PATCH v2 09/12] xfstests: skip generic/076 which cannot work on tmpfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

here, you were probably looking for -b option (that tests if its argument is a block device) instead of -d option (that tests if its argument is a directory). Otherwise, this patch would skip the test case for an arbitrary file system.

-Boris

----- Original Message -----
> Skip generic/076 which tests concurrent access while testing tmpfs
> because there are other tests cover the case using fsstress.
> 
> Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx>
> Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
> Signed-off-by: Junho Ryu <jayr@xxxxxxxxxx>
> ---
> 
> v2: check whether SCRATCH_DEV is a block device instead of checking whether
>     FSTYP is tmpfs.
> 
>  tests/generic/076 | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/generic/076 b/tests/generic/076
> index a53840f..7ab2fbc 100755
> --- a/tests/generic/076
> +++ b/tests/generic/076
> @@ -57,6 +57,8 @@ _supported_os IRIX Linux
>  
>  _require_scratch
>  
> +[ -d "$SCRATCH_DEV" ] || _notrun "this test requires block device"
> +
>  echo "*** init fs"
>  
>  rm -f $seqres.full
> --
> 1.8.5.1
> 
> 

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux