On Sat, Dec 14, 2013 at 09:11:02AM +1100, Dave Chinner wrote: > I'll rework it, but hte main issue is that it has to be freed > regardless of the error value in commit record processing, so it's > not as simple as just freeing it on error.... Indeed, but think that's another reason to move the freeing to xlog_recover_process_data. Right now or with the proposed patch xlog_recover_commit_trans frees trans, but there's nothing that breaks out of the loop in xlog_recover_process_data after that case. By moving the freeing there for all cases we can add a corruption check for that case, and we have a single function that controls the lifetime of the xlog_recover structure. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
