On Fri, Dec 13, 2013 at 10:27:53PM +0800, Zhi Yong Wu wrote: > From: Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx> > > Enable O_TMPFILE support in linkat(). > For more info, please refer to: > http://oss.sgi.com/archives/xfs/2013-08/msg00341.html Generall you should provide all reasonable information in the changelog instead of linking to it. > + if (sip->i_d.di_nlink == 0) > + tres = &M_RES(mp)->tr_link_tmpfile; > + else > + tres = &M_RES(mp)->tr_link; As mentioned before I think Dave wanted you to always use the same reservation, but I'll leave that discussion to him. > +/* For creating a link to an O_TMPFILE inode, except modifying > + * those metadata for regular inode, we still need to remove an inode > + * from unlinked list at first. That is, we can modify: > + * the agi hash list and counters: sector size > + * the on disk inode before ours in the agi hash list: inode cluster size > + */ We always have an emptry content /* line at the beginning of comments in XFS and the Linux kernel in general. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs