Looks good. Reviewed-by: Christoph Hellwig <hch@xxxxxx> Two very minor nitpicks below: > + int stripe_align; > > ASSERT(ap->length); > > mp = ap->ip->i_mount; > + > + /* stripe alignment for allocation is determined by mount parameters */ > + stripe_align = 0; > + if (mp->m_swidth && (mp->m_flags & XFS_MOUNT_SWALLOC)) > + stripe_align = mp->m_swidth; > + else if (mp->m_dalign) > + stripe_align = mp->m_dalign; nipick: I'd either initialize the variable to zero at the point of the declaration or do if .. else if .. else here. > } > + > + > nullfb = *ap->firstblock == NULLFSBLOCK; Two newlines seem odd here. I'd support one even if that's an unrelated change :) _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
