On Wed, Dec 04, 2013 at 05:01:44PM -0500, Chris Mason wrote: > Quoting Ben Myers (2013-12-04 16:25:04) > > Hey Christoph, > > > > On Tue, Nov 19, 2013 at 07:17:07AM -0800, Christoph Hellwig wrote: > > > Currently notify_change directly updates i_version for size updates, > > > which not only is counter to how all other fields are updated through > > > struct iattr, but also breaks XFS, which need inode updates to happen > > > under its own lock, and synchronized to the structure that gets written > > > to the log. > > > > > > Remove the update in the common code, and it to btrfs and ext4, > > > XFS already does a proper updaste internally and currently gets a > > > double update with the existing code. > > > > > > IMHO this is 3.13 and -stable material and should go in through the XFS > > > tree. > > > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > > > Does this still need a btrfs ack, or is it ready to go? > > The btrfs parts look good to me. > > Signed-off-by: Chris Mason <clm@xxxxxx> Great. Applied to the xfs tree as per Christoph's suggestion. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
