Re: [PATCH 2/2] xfs free the list of recovery items on error.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 02, 2013 at 07:51:12AM -0500, Mark Tinguely wrote:
> Recovery builds a list of items on the transaction's
> r_itemq head. Normally these items are committed and freed.
> But in the event of a recovery error, these allocations
> are leaked.
> 
> If the error occurs during item reordering, then reconstruct
> the r_itemq list before deleting the list to avoid leaking
> the entries that were on one of the temporary lists.
> 
> Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>

Looks good to me.
Reviewed-by: Ben Myers <bpm@xxxxxxx>

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux