> + const char name; > + const char *subopts[MAX_SUBOPTS]; > + struct subopt_param { > + int index; > + long long minval; > + long long maxval; > + } subopt_params[MAX_SUBOPTS]; > +}; Any reason to have a separate array for subopts instead of moving it into struct subopt_param? Except for that I really like the approach! Reviewed-by: Christoph Hellwig <hch@xxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs