On Tue, Nov 26, 2013 at 02:01:17PM +0800, Miao Xie wrote: > Btrfs would crash when the users wrote some data into a file with compress > flag but the compression of the fs was disabled. This test case is to check > this bug still happen or not. > > Signed-off-by: Miao Xie <miaox@xxxxxxxxxxxxxx> > --- > Changlog v1 -> v2: > - address the commit from Dave Chinner. Testing every change before posting them for review is a good habit to develop. This: > + $XFS_IO_PROG -f -c "pwrite 0 1M" -c sync $work_file | _filter_xfs_io will dump this: wrote 1048576/1048576 bytes at offset 0 XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) command "sync" not found into the output file and hence the test will fail as the golden image file in the patch was not updated to match the new test output. It also points out that "-c sync" command is invalid - the command to fsync a file is "-c fsync". Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
