On Tue, Nov 26, 2013 at 07:45:25AM +1100, Dave Chinner wrote: > I think the current code could be changed first, just to remove the > special cases (i.e. the ifdef NATIVE_HOST/else conditionals) by > always calling xfs_inode_item_format_extents(). That's easy enough > to do and then the iop_format change can simple change it to calling > xfs_iextent_copy() directly... Ok, I can do that. > I'd prefer to have a helper than have the same boilerplate code > repeated 14 times purely from a maintenance POV. It's easy to find > all the callers, it's easy to check that they do the right thing, > and in future there's only one piece of code to modify for all the > simple log item formatting operations.... I'll resent with it re-added. The reason it confused me is that only the len argument ever got used twice in the helper, otherwise it's just a bunch of assignment using a disjoint arguments. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
